Remove dead jsonargparse<4.39 skip guards#21848
Merged
tchaton merged 1 commit intoJul 20, 2026
Merged
Conversation
bhimrazy
requested review from
ethanwharris,
justusschock and
tchaton
as code owners
July 19, 2026 16:06
|
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #21848 +/- ##
=========================================
- Coverage 87% 79% -8%
=========================================
Files 270 267 -3
Lines 24074 24015 -59
=========================================
- Hits 20906 18867 -2039
- Misses 3168 5148 +1980 |
tchaton
approved these changes
Jul 20, 2026
Rishikmanche
pushed a commit
to Rishikmanche/pytorch-lightning
that referenced
this pull request
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes
@pytest.mark.skipif(compare_version("jsonargparse", operator.lt, "4.39"), ...)guards intest_cli.py— the jsonargparse floor is pinned to>=4.39.0inrequirements/pytorch/extra.txt, so these were always false. Also drops the now-unusedoperatorandcompare_versionimports.